> > ErrorHandler needs an error method in addition to fatal and warning. It
> > would be better if all methods had a single argument of XmlException.
> >
>
> For callbacks I am not so sure that you need a new Exception to encapsulate data
> that could be passed as arguments.
We don't need a new one: we have one already. The advantage of passing
an object is that it's easier for parsers to provide richer error
information (by subclassing XmlException).
> > Is AttributeMap required to implement clone? I think it probably ought
> > to be.
> I am not sure why it is necessary to be clonable.
Because the spec says:
* <p>This map will be valid only during the invocation of the
* <code>startElement</code> callback: if you need to use attribute
* information elsewhere, you will need to make your own copies.</p>
If it doesn't implement cloneable, how do you make your own copy?
James